Deprecate PROFILING_HEAP_ENABLED_DEFAULT and update metadata default#11089
Draft
Deprecate PROFILING_HEAP_ENABLED_DEFAULT and update metadata default#11089
Conversation
… default to true Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 60 metrics, 11 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.62.0-SNAPSHOT~df09751f7e, baseline=1.62.0-SNAPSHOT~5ab378f780
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.054 s) : 0, 1054478
Total [baseline] (11.071 s) : 0, 11070972
Agent [candidate] (1.062 s) : 0, 1061697
Total [candidate] (11.098 s) : 0, 11097925
section appsec
Agent [baseline] (1.246 s) : 0, 1245513
Total [baseline] (11.074 s) : 0, 11074408
Agent [candidate] (1.248 s) : 0, 1247753
Total [candidate] (11.142 s) : 0, 11141962
section iast
Agent [baseline] (1.238 s) : 0, 1238477
Total [baseline] (11.343 s) : 0, 11343433
Agent [candidate] (1.226 s) : 0, 1226030
Total [candidate] (11.37 s) : 0, 11369532
section profiling
Agent [baseline] (1.187 s) : 0, 1186576
Total [baseline] (11.015 s) : 0, 11015011
Agent [candidate] (1.192 s) : 0, 1192369
Total [candidate] (11.089 s) : 0, 11088584
gantt
title petclinic - break down per module: candidate=1.62.0-SNAPSHOT~df09751f7e, baseline=1.62.0-SNAPSHOT~5ab378f780
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.224 ms) : 0, 1224
crashtracking [candidate] (1.227 ms) : 0, 1227
BytebuddyAgent [baseline] (632.24 ms) : 0, 632240
BytebuddyAgent [candidate] (637.081 ms) : 0, 637081
AgentMeter [baseline] (29.32 ms) : 0, 29320
AgentMeter [candidate] (29.507 ms) : 0, 29507
GlobalTracer [baseline] (248.451 ms) : 0, 248451
GlobalTracer [candidate] (249.482 ms) : 0, 249482
AppSec [baseline] (31.968 ms) : 0, 31968
AppSec [candidate] (32.352 ms) : 0, 32352
Debugger [baseline] (59.845 ms) : 0, 59845
Debugger [candidate] (60.393 ms) : 0, 60393
Remote Config [baseline] (589.313 µs) : 0, 589
Remote Config [candidate] (599.514 µs) : 0, 600
Telemetry [baseline] (8.124 ms) : 0, 8124
Telemetry [candidate] (8.18 ms) : 0, 8180
Flare Poller [baseline] (6.572 ms) : 0, 6572
Flare Poller [candidate] (6.648 ms) : 0, 6648
section appsec
crashtracking [baseline] (1.231 ms) : 0, 1231
crashtracking [candidate] (1.214 ms) : 0, 1214
BytebuddyAgent [baseline] (661.194 ms) : 0, 661194
BytebuddyAgent [candidate] (661.313 ms) : 0, 661313
AgentMeter [baseline] (12.063 ms) : 0, 12063
AgentMeter [candidate] (12.056 ms) : 0, 12056
GlobalTracer [baseline] (247.9 ms) : 0, 247900
GlobalTracer [candidate] (248.646 ms) : 0, 248646
AppSec [baseline] (184.075 ms) : 0, 184075
AppSec [candidate] (184.411 ms) : 0, 184411
Debugger [baseline] (65.593 ms) : 0, 65593
Debugger [candidate] (66.364 ms) : 0, 66364
Remote Config [baseline] (611.614 µs) : 0, 612
Remote Config [candidate] (603.539 µs) : 0, 604
Telemetry [baseline] (8.502 ms) : 0, 8502
Telemetry [candidate] (8.664 ms) : 0, 8664
Flare Poller [baseline] (3.522 ms) : 0, 3522
Flare Poller [candidate] (3.639 ms) : 0, 3639
IAST [baseline] (24.486 ms) : 0, 24486
IAST [candidate] (24.56 ms) : 0, 24560
section iast
crashtracking [baseline] (1.241 ms) : 0, 1241
crashtracking [candidate] (1.211 ms) : 0, 1211
BytebuddyAgent [baseline] (812.247 ms) : 0, 812247
BytebuddyAgent [candidate] (803.182 ms) : 0, 803182
AgentMeter [baseline] (11.641 ms) : 0, 11641
AgentMeter [candidate] (11.353 ms) : 0, 11353
GlobalTracer [baseline] (240.487 ms) : 0, 240487
GlobalTracer [candidate] (238.824 ms) : 0, 238824
AppSec [baseline] (29.739 ms) : 0, 29739
AppSec [candidate] (33.493 ms) : 0, 33493
Debugger [baseline] (62.43 ms) : 0, 62430
Debugger [candidate] (59.14 ms) : 0, 59140
Remote Config [baseline] (523.924 µs) : 0, 524
Remote Config [candidate] (1.685 ms) : 0, 1685
Telemetry [baseline] (13.792 ms) : 0, 13792
Telemetry [candidate] (11.569 ms) : 0, 11569
Flare Poller [baseline] (3.651 ms) : 0, 3651
Flare Poller [candidate] (3.531 ms) : 0, 3531
IAST [baseline] (25.995 ms) : 0, 25995
IAST [candidate] (25.729 ms) : 0, 25729
section profiling
crashtracking [baseline] (1.185 ms) : 0, 1185
crashtracking [candidate] (1.188 ms) : 0, 1188
BytebuddyAgent [baseline] (692.778 ms) : 0, 692778
BytebuddyAgent [candidate] (696.352 ms) : 0, 696352
AgentMeter [baseline] (9.116 ms) : 0, 9116
AgentMeter [candidate] (9.15 ms) : 0, 9150
GlobalTracer [baseline] (207.393 ms) : 0, 207393
GlobalTracer [candidate] (208.368 ms) : 0, 208368
AppSec [baseline] (32.757 ms) : 0, 32757
AppSec [candidate] (32.789 ms) : 0, 32789
Debugger [baseline] (65.82 ms) : 0, 65820
Debugger [candidate] (65.934 ms) : 0, 65934
Remote Config [baseline] (579.099 µs) : 0, 579
Remote Config [candidate] (577.055 µs) : 0, 577
Telemetry [baseline] (7.875 ms) : 0, 7875
Telemetry [candidate] (7.902 ms) : 0, 7902
Flare Poller [baseline] (3.587 ms) : 0, 3587
Flare Poller [candidate] (3.588 ms) : 0, 3588
ProfilingAgent [baseline] (94.305 ms) : 0, 94305
ProfilingAgent [candidate] (95.315 ms) : 0, 95315
Profiling [baseline] (94.888 ms) : 0, 94888
Profiling [candidate] (95.887 ms) : 0, 95887
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.62.0-SNAPSHOT~df09751f7e, baseline=1.62.0-SNAPSHOT~5ab378f780
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.058 s) : 0, 1057972
Total [baseline] (8.834 s) : 0, 8834305
Agent [candidate] (1.061 s) : 0, 1060802
Total [candidate] (8.845 s) : 0, 8844875
section iast
Agent [baseline] (1.229 s) : 0, 1229332
Total [baseline] (9.557 s) : 0, 9556562
Agent [candidate] (1.222 s) : 0, 1222131
Total [candidate] (9.574 s) : 0, 9574062
gantt
title insecure-bank - break down per module: candidate=1.62.0-SNAPSHOT~df09751f7e, baseline=1.62.0-SNAPSHOT~5ab378f780
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.235 ms) : 0, 1235
crashtracking [candidate] (1.231 ms) : 0, 1231
BytebuddyAgent [baseline] (634.337 ms) : 0, 634337
BytebuddyAgent [candidate] (632.677 ms) : 0, 632677
AgentMeter [baseline] (29.47 ms) : 0, 29470
AgentMeter [candidate] (29.59 ms) : 0, 29590
GlobalTracer [baseline] (249.871 ms) : 0, 249871
GlobalTracer [candidate] (251.585 ms) : 0, 251585
AppSec [baseline] (32.255 ms) : 0, 32255
AppSec [candidate] (32.786 ms) : 0, 32786
Debugger [baseline] (59.35 ms) : 0, 59350
Debugger [candidate] (60.445 ms) : 0, 60445
Remote Config [baseline] (599.791 µs) : 0, 600
Remote Config [candidate] (610.94 µs) : 0, 611
Telemetry [baseline] (8.096 ms) : 0, 8096
Telemetry [candidate] (8.264 ms) : 0, 8264
Flare Poller [baseline] (6.615 ms) : 0, 6615
Flare Poller [candidate] (7.517 ms) : 0, 7517
section iast
crashtracking [baseline] (1.23 ms) : 0, 1230
crashtracking [candidate] (1.22 ms) : 0, 1220
BytebuddyAgent [baseline] (806.712 ms) : 0, 806712
BytebuddyAgent [candidate] (800.788 ms) : 0, 800788
AgentMeter [baseline] (11.47 ms) : 0, 11470
AgentMeter [candidate] (11.367 ms) : 0, 11367
GlobalTracer [baseline] (238.79 ms) : 0, 238790
GlobalTracer [candidate] (238.955 ms) : 0, 238955
AppSec [baseline] (30.375 ms) : 0, 30375
AppSec [candidate] (30.96 ms) : 0, 30960
Debugger [baseline] (62.826 ms) : 0, 62826
Debugger [candidate] (60.273 ms) : 0, 60273
Remote Config [baseline] (533.599 µs) : 0, 534
Remote Config [candidate] (531.912 µs) : 0, 532
Telemetry [baseline] (11.772 ms) : 0, 11772
Telemetry [candidate] (12.896 ms) : 0, 12896
Flare Poller [baseline] (3.469 ms) : 0, 3469
Flare Poller [candidate] (3.427 ms) : 0, 3427
IAST [baseline] (25.772 ms) : 0, 25772
IAST [candidate] (25.709 ms) : 0, 25709
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 5 performance regressions! Performance is the same for 14 metrics, 17 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.62.0-SNAPSHOT~df09751f7e, baseline=1.62.0-SNAPSHOT~5ab378f780
dateFormat X
axisFormat %s
section baseline
no_agent (18.245 ms) : 18058, 18433
. : milestone, 18245,
appsec (18.756 ms) : 18565, 18947
. : milestone, 18756,
code_origins (18.029 ms) : 17848, 18209
. : milestone, 18029,
iast (18.312 ms) : 18131, 18492
. : milestone, 18312,
profiling (18.704 ms) : 18514, 18894
. : milestone, 18704,
tracing (17.788 ms) : 17615, 17961
. : milestone, 17788,
section candidate
no_agent (18.426 ms) : 18237, 18616
. : milestone, 18426,
appsec (18.564 ms) : 18380, 18749
. : milestone, 18564,
code_origins (17.856 ms) : 17677, 18036
. : milestone, 17856,
iast (18.191 ms) : 18008, 18374
. : milestone, 18191,
profiling (20.333 ms) : 20132, 20534
. : milestone, 20333,
tracing (18.922 ms) : 18733, 19110
. : milestone, 18922,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.62.0-SNAPSHOT~df09751f7e, baseline=1.62.0-SNAPSHOT~5ab378f780
dateFormat X
axisFormat %s
section baseline
no_agent (1.249 ms) : 1237, 1262
. : milestone, 1249,
iast (3.344 ms) : 3296, 3393
. : milestone, 3344,
iast_FULL (5.996 ms) : 5935, 6056
. : milestone, 5996,
iast_GLOBAL (3.642 ms) : 3586, 3698
. : milestone, 3642,
profiling (2.183 ms) : 2163, 2202
. : milestone, 2183,
tracing (1.854 ms) : 1838, 1870
. : milestone, 1854,
section candidate
no_agent (1.26 ms) : 1248, 1272
. : milestone, 1260,
iast (3.296 ms) : 3245, 3347
. : milestone, 3296,
iast_FULL (6.117 ms) : 6054, 6180
. : milestone, 6117,
iast_GLOBAL (3.721 ms) : 3657, 3785
. : milestone, 3721,
profiling (2.477 ms) : 2452, 2502
. : milestone, 2477,
tracing (1.899 ms) : 1883, 1915
. : milestone, 1899,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.62.0-SNAPSHOT~df09751f7e, baseline=1.62.0-SNAPSHOT~5ab378f780
dateFormat X
axisFormat %s
section baseline
no_agent (1.484 ms) : 1473, 1496
. : milestone, 1484,
appsec (3.752 ms) : 3535, 3970
. : milestone, 3752,
iast (2.261 ms) : 2192, 2330
. : milestone, 2261,
iast_GLOBAL (2.304 ms) : 2234, 2373
. : milestone, 2304,
profiling (2.083 ms) : 2028, 2137
. : milestone, 2083,
tracing (2.061 ms) : 2008, 2115
. : milestone, 2061,
section candidate
no_agent (1.485 ms) : 1474, 1497
. : milestone, 1485,
appsec (3.819 ms) : 3597, 4041
. : milestone, 3819,
iast (2.268 ms) : 2199, 2337
. : milestone, 2268,
iast_GLOBAL (2.306 ms) : 2237, 2376
. : milestone, 2306,
profiling (2.102 ms) : 2047, 2157
. : milestone, 2102,
tracing (2.074 ms) : 2020, 2128
. : milestone, 2074,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.62.0-SNAPSHOT~df09751f7e, baseline=1.62.0-SNAPSHOT~5ab378f780
dateFormat X
axisFormat %s
section baseline
no_agent (14.976 s) : 14976000, 14976000
. : milestone, 14976000,
appsec (14.764 s) : 14764000, 14764000
. : milestone, 14764000,
iast (18.254 s) : 18254000, 18254000
. : milestone, 18254000,
iast_GLOBAL (17.886 s) : 17886000, 17886000
. : milestone, 17886000,
profiling (15.415 s) : 15415000, 15415000
. : milestone, 15415000,
tracing (14.896 s) : 14896000, 14896000
. : milestone, 14896000,
section candidate
no_agent (15.019 s) : 15019000, 15019000
. : milestone, 15019000,
appsec (14.764 s) : 14764000, 14764000
. : milestone, 14764000,
iast (18.449 s) : 18449000, 18449000
. : milestone, 18449000,
iast_GLOBAL (17.937 s) : 17937000, 17937000
. : milestone, 17937000,
profiling (15.393 s) : 15393000, 15393000
. : milestone, 15393000,
tracing (15.373 s) : 15373000, 15373000
. : milestone, 15373000,
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Marks
PROFILING_HEAP_ENABLED_DEFAULTas@DeprecatedinProfilingConfigand updates theDD_PROFILING_HEAP_ENABLEDmetadata entry default from"false"to"true".Motivation
The
profiling.heap.enabledconfig now defaults toisLiveHeapProfilingSafe()— a dynamic predicate that returnstrueon JVMs where either ddprof live heap or JFR OldObjectSample is safely available (merged in #11039). As a result:PROFILING_HEAP_ENABLED_DEFAULT = falseis dead code with no callers; it is a misleading artefact of the old static default. It is kept as a@Deprecatedconstant (rather than removed) to avoid a binary-incompatible change for external consumers of thedd-trace-apilibrary.metadata/supported-configurations.jsonentry forDD_PROFILING_HEAP_ENABLEDstill declared"default": "false", misrepresenting the new effective default to tooling and documentation generators.Additional Notes
No behaviour changes — purely a metadata and deprecation annotation update.
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: PROF-10633